Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Side by Side Diff: extensions/common/permissions/media_galleries_permission_data.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/common/permissions/media_galleries_permission_data.h" 5 #include "extensions/common/permissions/media_galleries_permission_data.h"
6 6
7 #include "base/strings/string_util.h" 7 #include "base/strings/string_util.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "extensions/common/permissions/media_galleries_permission.h" 9 #include "extensions/common/permissions/media_galleries_permission.h"
10 10
11 namespace extensions { 11 namespace extensions {
12 12
13 MediaGalleriesPermissionData::MediaGalleriesPermissionData() { 13 MediaGalleriesPermissionData::MediaGalleriesPermissionData() {
14 } 14 }
15 15
16 bool MediaGalleriesPermissionData::Check( 16 bool MediaGalleriesPermissionData::Check(
17 const APIPermission::CheckParam* param) const { 17 const APIPermission::CheckParam* param) const {
18 if (!param) 18 if (!param)
19 return false; 19 return false;
20 20
21 const MediaGalleriesPermission::CheckParam& specific_param = 21 const MediaGalleriesPermission::CheckParam& specific_param =
22 *static_cast<const MediaGalleriesPermission::CheckParam*>(param); 22 *static_cast<const MediaGalleriesPermission::CheckParam*>(param);
23 return permission_ == specific_param.permission; 23 return permission_ == specific_param.permission;
24 } 24 }
25 25
26 std::unique_ptr<base::Value> MediaGalleriesPermissionData::ToValue() const { 26 std::unique_ptr<base::Value> MediaGalleriesPermissionData::ToValue() const {
27 return std::unique_ptr<base::Value>(new base::StringValue(permission_)); 27 return std::unique_ptr<base::Value>(new base::Value(permission_));
28 } 28 }
29 29
30 bool MediaGalleriesPermissionData::FromValue(const base::Value* value) { 30 bool MediaGalleriesPermissionData::FromValue(const base::Value* value) {
31 if (!value) 31 if (!value)
32 return false; 32 return false;
33 33
34 std::string raw_permission; 34 std::string raw_permission;
35 if (!value->GetAsString(&raw_permission)) 35 if (!value->GetAsString(&raw_permission))
36 return false; 36 return false;
37 37
(...skipping 14 matching lines...) Expand all
52 const MediaGalleriesPermissionData& rhs) const { 52 const MediaGalleriesPermissionData& rhs) const {
53 return permission_ < rhs.permission_; 53 return permission_ < rhs.permission_;
54 } 54 }
55 55
56 bool MediaGalleriesPermissionData::operator==( 56 bool MediaGalleriesPermissionData::operator==(
57 const MediaGalleriesPermissionData& rhs) const { 57 const MediaGalleriesPermissionData& rhs) const {
58 return permission_ == rhs.permission_; 58 return permission_ == rhs.permission_;
59 } 59 }
60 60
61 } // namespace extensions 61 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/common/extension_l10n_util.cc ('k') | extensions/common/permissions/settings_override_permission.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698