Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: chromeos/network/onc/onc_utils.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/onc/onc_translator_shill_to_onc.cc ('k') | chromeos/network/proxy/proxy_config_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/onc/onc_utils.cc
diff --git a/chromeos/network/onc/onc_utils.cc b/chromeos/network/onc/onc_utils.cc
index 4f956c4167bcdb05d68e844f09616f40cd46418e..a2c2d32545d483357cd0bebbabb310a5ac99cdc6 100644
--- a/chromeos/network/onc/onc_utils.cc
+++ b/chromeos/network/onc/onc_utils.cc
@@ -353,7 +353,7 @@ class OncMaskValues : public Mapper {
bool* found_unknown_field,
bool* error) override {
if (FieldIsCredential(object_signature, field_name)) {
- return std::unique_ptr<base::Value>(new base::StringValue(mask_));
+ return std::unique_ptr<base::Value>(new base::Value(mask_));
} else {
return Mapper::MapField(field_name, object_signature, onc_value,
found_unknown_field, error);
@@ -790,8 +790,8 @@ bool IsRecommendedValue(const base::DictionaryValue* onc,
const base::ListValue* recommended_keys = nullptr;
return (onc->GetList(recommended_property_key, &recommended_keys) &&
- recommended_keys->Find(base::StringValue(property_basename)) !=
- recommended_keys->end());
+ recommended_keys->Find(base::Value(property_basename)) !=
+ recommended_keys->end());
}
namespace {
« no previous file with comments | « chromeos/network/onc/onc_translator_shill_to_onc.cc ('k') | chromeos/network/proxy/proxy_config_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698