chromeos/dbus/shill_service_client_unittest.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/shill_service_client_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/shill_service_client_unittest.cc

diff --git a/chromeos/dbus/shill_service_client_unittest.cc b/chromeos/dbus/shill_service_client_unittest.cc

index b53e5cad0b6699fef3530d13078afc15df50c1f7..7adc82850dcc43007613fbb2c886ca2d81706ade 100644

--- a/chromeos/dbus/shill_service_client_unittest.cc

+++ b/chromeos/dbus/shill_service_client_unittest.cc

@@ -117,7 +117,7 @@ TEST_F(ShillServiceClientTest, SetProperty) {

std::unique_ptr<dbus::Response> response(dbus::Response::CreateEmpty());

// Set expectations.

- const base::StringValue value(kValue);

+ const base::Value value(kValue);

PrepareForMethodCall(shill::kSetPropertyFunction,

base::Bind(&ExpectStringAndValueArguments,

shill::kPassphraseProperty,