Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc
index 6a09c1113d32ea54c33323ef221d95a469a447a7..dfca5fd225af449984d57e12324e04a42d842fa3 100644
--- a/chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc
+++ b/chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc
@@ -42,7 +42,7 @@ bool WhitelistUser(OwnerSettingsServiceChromeOS* service,
if (CrosSettings::Get()->FindEmailInList(kAccountsPrefUsers, username, NULL))
return false;
if (service) {
- base::StringValue username_value(username);
+ base::Value username_value(username);
service->AppendToList(kAccountsPrefUsers, username_value);
}
return true;
@@ -127,7 +127,7 @@ void AccountsOptionsHandler::HandleUnwhitelistUser(
ProfileMetrics::LogProfileDeleteUser(ProfileMetrics::DELETE_PROFILE_SETTINGS);
- base::StringValue canonical_email(gaia::CanonicalizeEmail(email));
+ base::Value canonical_email(gaia::CanonicalizeEmail(email));
if (OwnerSettingsServiceChromeOS* service =
OwnerSettingsServiceChromeOS::FromWebUI(web_ui())) {
service->RemoveFromList(kAccountsPrefUsers, canonical_email);
@@ -168,8 +168,8 @@ void AccountsOptionsHandler::HandleUpdateWhitelist(
const user_manager::UserList& users =
user_manager::UserManager::Get()->GetUsers();
for (const auto* user : users) {
- new_list->AppendIfNotPresent(base::MakeUnique<base::StringValue>(
- user->GetAccountId().GetUserEmail()));
+ new_list->AppendIfNotPresent(
+ base::MakeUnique<base::Value>(user->GetAccountId().GetUserEmail()));
}
if (OwnerSettingsServiceChromeOS* service =

Powered by Google App Engine
This is Rietveld 408576698