Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3104)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/supervised_user/supervised_user_service.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/supervised_user/legacy/supervised_user_shared_settings_update_unittest.cc ('k') | chrome/browser/supervised_user/supervised_user_service_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/supervised_user/supervised_user_service.cc
diff --git a/chrome/browser/supervised_user/supervised_user_service.cc b/chrome/browser/supervised_user/supervised_user_service.cc
index 2f7f90490306357db4cf72cd3a50fe9fa0afe07e..0f67367dcfd10230077f3f0a028581d2fb1755e5 100644
--- a/chrome/browser/supervised_user/supervised_user_service.cc
+++ b/chrome/browser/supervised_user/supervised_user_service.cc
@@ -1180,7 +1180,7 @@ void SupervisedUserService::OnExtensionInstalled(
std::string key = SupervisedUserSettingsService::MakeSplitSettingKey(
supervised_users::kApprovedExtensions, id);
std::unique_ptr<base::Value> version_value(
- new base::StringValue(version.GetString()));
+ new base::Value(version.GetString()));
GetSettingsService()->UpdateSetting(key, std::move(version_value));
}
// Upon extension update, the approved version may (or may not) match the
« no previous file with comments | « chrome/browser/supervised_user/legacy/supervised_user_shared_settings_update_unittest.cc ('k') | chrome/browser/supervised_user/supervised_user_service_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698