Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: extensions/browser/value_store/value_store_change_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/value_store/value_store_change_unittest.cc
diff --git a/extensions/browser/value_store/value_store_change_unittest.cc b/extensions/browser/value_store/value_store_change_unittest.cc
index ef4934a72e7f7715f2e3d672728beff1c763e352..10fd6a0915cdd18ec5ac637d91205cf32fe7156b 100644
--- a/extensions/browser/value_store/value_store_change_unittest.cc
+++ b/extensions/browser/value_store/value_store_change_unittest.cc
@@ -20,40 +20,39 @@ namespace {
TEST(ValueStoreChangeTest, NullOldValue) {
ValueStoreChange change("key", nullptr,
- base::MakeUnique<base::StringValue>("value"));
+ base::MakeUnique<base::Value>("value"));
EXPECT_EQ("key", change.key());
EXPECT_EQ(NULL, change.old_value());
{
- base::StringValue expected("value");
+ base::Value expected("value");
EXPECT_TRUE(change.new_value()->Equals(&expected));
}
}
TEST(ValueStoreChangeTest, NullNewValue) {
- ValueStoreChange change("key", base::MakeUnique<base::StringValue>("value"),
+ ValueStoreChange change("key", base::MakeUnique<base::Value>("value"),
nullptr);
EXPECT_EQ("key", change.key());
{
- base::StringValue expected("value");
+ base::Value expected("value");
EXPECT_TRUE(change.old_value()->Equals(&expected));
}
EXPECT_EQ(NULL, change.new_value());
}
TEST(ValueStoreChangeTest, NonNullValues) {
- ValueStoreChange change("key",
- base::MakeUnique<base::StringValue>("old_value"),
- base::MakeUnique<base::StringValue>("new_value"));
+ ValueStoreChange change("key", base::MakeUnique<base::Value>("old_value"),
+ base::MakeUnique<base::Value>("new_value"));
EXPECT_EQ("key", change.key());
{
- base::StringValue expected("old_value");
+ base::Value expected("old_value");
EXPECT_TRUE(change.old_value()->Equals(&expected));
}
{
- base::StringValue expected("new_value");
+ base::Value expected("new_value");
EXPECT_TRUE(change.new_value()->Equals(&expected));
}
}

Powered by Google App Engine
This is Rietveld 408576698