Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1603)

Unified Diff: chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc
diff --git a/chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc b/chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc
index 170a37fabf0cac0b0d3106e869ed659c3a6a1747..cdaa34db3184db2b36ac0d62377258c00bf9fe7c 100644
--- a/chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc
+++ b/chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc
@@ -58,14 +58,13 @@ TEST(ExtensionPermissionsAPIHelpers, Pack) {
std::string expected_apis[] = {"tabs", "fileBrowserHandler",
"fileBrowserHandlerInternal"};
for (size_t i = 0; i < arraysize(expected_apis); ++i) {
- std::unique_ptr<base::Value> value(new base::StringValue(expected_apis[i]));
+ std::unique_ptr<base::Value> value(new base::Value(expected_apis[i]));
EXPECT_NE(api_list->end(), api_list->Find(*value));
}
std::string expected_origins[] = { "http://a.com/*", "http://b.com/*" };
for (size_t i = 0; i < arraysize(expected_origins); ++i) {
- std::unique_ptr<base::Value> value(
- new base::StringValue(expected_origins[i]));
+ std::unique_ptr<base::Value> value(new base::Value(expected_origins[i]));
EXPECT_NE(origin_list->end(), origin_list->Find(*value));
}

Powered by Google App Engine
This is Rietveld 408576698