Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: components/prefs/default_pref_store_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/prefs/command_line_pref_store.cc ('k') | components/prefs/json_pref_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/prefs/default_pref_store_unittest.cc
diff --git a/components/prefs/default_pref_store_unittest.cc b/components/prefs/default_pref_store_unittest.cc
index af6a074857501e2432d0b9742f3eb48809bfaf42..20bbba3a87ff912f84acf743fbe186a4ed04a261 100644
--- a/components/prefs/default_pref_store_unittest.cc
+++ b/components/prefs/default_pref_store_unittest.cc
@@ -6,7 +6,6 @@
#include "components/prefs/default_pref_store.h"
#include "testing/gtest/include/gtest/gtest.h"
-using base::StringValue;
using base::Value;
namespace {
@@ -54,17 +53,17 @@ TEST(DefaultPrefStoreTest, NotifyPrefValueChanged) {
// Setting a default value shouldn't send a change notification.
pref_store->SetDefaultValue(kPrefKey,
- std::unique_ptr<Value>(new StringValue("foo")));
+ std::unique_ptr<Value>(new Value("foo")));
EXPECT_EQ(0, observer.change_count());
// Replacing the default value should send a change notification...
- pref_store->ReplaceDefaultValue(
- kPrefKey, std::unique_ptr<Value>(new StringValue("bar")));
+ pref_store->ReplaceDefaultValue(kPrefKey,
+ std::unique_ptr<Value>(new Value("bar")));
EXPECT_EQ(1, observer.change_count());
// But only if the value actually changed.
- pref_store->ReplaceDefaultValue(
- kPrefKey, std::unique_ptr<Value>(new StringValue("bar")));
+ pref_store->ReplaceDefaultValue(kPrefKey,
+ std::unique_ptr<Value>(new Value("bar")));
EXPECT_EQ(1, observer.change_count());
}
« no previous file with comments | « components/prefs/command_line_pref_store.cc ('k') | components/prefs/json_pref_store_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698