Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2834)

Unified Diff: base/trace_event/trace_event_argument.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/test/values_test_util.cc ('k') | base/trace_event/trace_event_memory_overhead.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/trace_event_argument.cc
diff --git a/base/trace_event/trace_event_argument.cc b/base/trace_event/trace_event_argument.cc
index da33c6da00438f5e5f691d5e0001b387679b3156..db702b6231e5249c9526d27ac439450c732e39a6 100644
--- a/base/trace_event/trace_event_argument.cc
+++ b/base/trace_event/trace_event_argument.cc
@@ -268,7 +268,7 @@ void TracedValue::SetBaseValueWithCopiedName(base::StringPiece name,
} break;
case base::Value::Type::STRING: {
- const StringValue* string_value;
+ const Value* string_value;
value.GetAsString(&string_value);
SetStringWithCopiedName(name, string_value->GetString());
} break;
@@ -322,7 +322,7 @@ void TracedValue::AppendBaseValue(const base::Value& value) {
} break;
case base::Value::Type::STRING: {
- const StringValue* string_value;
+ const Value* string_value;
value.GetAsString(&string_value);
AppendString(string_value->GetString());
} break;
« no previous file with comments | « base/test/values_test_util.cc ('k') | base/trace_event/trace_event_memory_overhead.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698