Remove base::StringValue

tools/clang/value_cleanup/ListValueRewriter.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ListValueRewriter.h"
 
 #include <assert.h>
 #include <algorithm>
 
 #include "clang/AST/ASTContext.h"
@@ skipping 390 matching lines @@
                         cxxNewExpr(has(cxxConstructExpr(
                             hasDeclaration(cxxMethodDecl(
                                 hasName("::base::Value::FundamentalValue"))),
                             argumentCountIs(1),
                             hasArgument(
                                 0, id("argExpr",
                                       expr(hasType(
                                           realFloatingPointType())))))))))))),
       &append_double_callback_);
 
-  // base::ListValue::Append(new base::StringValue(...))
+  // base::ListValue::Append(new base::Value(...))
   //     => base::ListValue::AppendString()
   match_finder->addMatcher(
       id("callExpr",
          cxxMemberCallExpr(
              is_list_append,
              hasArgument(
-                 0, ignoringParenImpCasts(id(
-                        "newExpr",
-                        cxxNewExpr(has(cxxConstructExpr(
-                            hasDeclaration(cxxMethodDecl(
-                                hasName("::base::StringValue::StringValue"))),
-                            argumentCountIs(1),
-                            hasArgument(0, id("argExpr", expr())))))))))),
+                 0, ignoringParenImpCasts(
+                        id("newExpr",
+                           cxxNewExpr(has(cxxConstructExpr(
+                               hasDeclaration(cxxMethodDecl(
+                                   hasName("::base::Value::StringValue"))),
+                               argumentCountIs(1),
+                               hasArgument(0, id("argExpr", expr())))))))))),
       &append_string_callback_);
 
   auto is_unique_ptr_release =
       allOf(callee(cxxMethodDecl(
                 hasName("release"),
                 ofClass(cxxRecordDecl(hasName("::std::unique_ptr"))))),
             argumentCountIs(0));
 
   // base::ListValue::Append(ReturnsUniquePtr().release())
   //     => base::ListValue::Append(ReturnsUniquePtr())
@@ skipping 38 matching lines @@
                           anyOf(hasInitializer(
                                     // Note this won't match C++11 uniform
                                     // initialization syntax, since the
                                     // CXXNewExpr is wrapped in an
                                     // InitListExpr in that case.
                                     ignoringParenImpCasts(cxxNewExpr())),
                                 unless(hasInitializer(expr()))),
                           unless(parmVarDecl()))))))))),
       &append_raw_ptr_callback_);
 }