extensions/browser/api/metrics_private/metrics_private_api.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/metrics_private/metrics_private_api.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/metrics_private/metrics_private_api.cc

diff --git a/extensions/browser/api/metrics_private/metrics_private_api.cc b/extensions/browser/api/metrics_private/metrics_private_api.cc

index 844a056c04f2328d6683dd0a46bd113f917676e6..c1be31677ea1e27af472507f52ffa651ab2a0be4 100644

--- a/extensions/browser/api/metrics_private/metrics_private_api.cc

+++ b/extensions/browser/api/metrics_private/metrics_private_api.cc

@@ -52,8 +52,8 @@ ExtensionFunction::ResponseAction MetricsPrivateGetFieldTrialFunction::Run() {

std::string name;

EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &name));

- return RespondNow(OneArgument(base::MakeUnique<base::StringValue>(

- base::FieldTrialList::FindFullName(name))));

+ return RespondNow(OneArgument(

+ base::MakeUnique<base::Value>(base::FieldTrialList::FindFullName(name))));

}

ExtensionFunction::ResponseAction