Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2720)

Unified Diff: chrome/browser/ui/webui/extensions/extension_loader_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_loader_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_loader_handler.cc b/chrome/browser/ui/webui/extensions/extension_loader_handler.cc
index 88c7485b7ba18ff583a4282cfee28366d42a5d7f..e2e40ce189e526bbd778144cc69b509c7f47c9f8 100644
--- a/chrome/browser/ui/webui/extensions/extension_loader_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_loader_handler.cc
@@ -197,9 +197,8 @@ void ExtensionLoaderHandler::AddFailure(
highlighter.SetHighlightedRegions(manifest_value.get());
std::unique_ptr<base::DictionaryValue> failure(new base::DictionaryValue());
- failure->Set("path",
- new base::StringValue(prettified_path.LossyDisplayName()));
- failure->Set("error", new base::StringValue(base::UTF8ToUTF16(error)));
+ failure->Set("path", new base::Value(prettified_path.LossyDisplayName()));
+ failure->Set("error", new base::Value(base::UTF8ToUTF16(error)));
failure->Set("manifest", manifest_value.release());
failures_.Append(std::move(failure));
« no previous file with comments | « chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc ('k') | chrome/browser/ui/webui/help/help_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698