Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: components/policy/core/common/schema_registry_tracking_policy_provider_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/policy/core/common/schema_registry_tracking_policy_provider .h" 5 #include "components/policy/core/common/schema_registry_tracking_policy_provider .h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 Mock::VerifyAndClearExpectations(&mock_provider_); 78 Mock::VerifyAndClearExpectations(&mock_provider_);
79 79
80 const PolicyBundle empty_bundle; 80 const PolicyBundle empty_bundle;
81 EXPECT_TRUE( 81 EXPECT_TRUE(
82 schema_registry_tracking_provider_.policies().Equals(empty_bundle)); 82 schema_registry_tracking_provider_.policies().Equals(empty_bundle));
83 } 83 }
84 84
85 TEST_F(SchemaRegistryTrackingPolicyProviderTest, PassOnChromePolicy) { 85 TEST_F(SchemaRegistryTrackingPolicyProviderTest, PassOnChromePolicy) {
86 PolicyBundle bundle; 86 PolicyBundle bundle;
87 const PolicyNamespace chrome_ns(POLICY_DOMAIN_CHROME, ""); 87 const PolicyNamespace chrome_ns(POLICY_DOMAIN_CHROME, "");
88 bundle.Get(chrome_ns).Set( 88 bundle.Get(chrome_ns).Set("policy", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
89 "policy", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD, 89 POLICY_SOURCE_CLOUD,
90 base::MakeUnique<base::StringValue>("visible"), nullptr); 90 base::MakeUnique<base::Value>("visible"), nullptr);
91 91
92 EXPECT_CALL(observer_, OnUpdatePolicy(&schema_registry_tracking_provider_)); 92 EXPECT_CALL(observer_, OnUpdatePolicy(&schema_registry_tracking_provider_));
93 std::unique_ptr<PolicyBundle> delegate_bundle(new PolicyBundle); 93 std::unique_ptr<PolicyBundle> delegate_bundle(new PolicyBundle);
94 delegate_bundle->CopyFrom(bundle); 94 delegate_bundle->CopyFrom(bundle);
95 delegate_bundle->Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, "xyz")) 95 delegate_bundle->Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, "xyz"))
96 .Set("foo", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, 96 .Set("foo", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
97 POLICY_SOURCE_CLOUD, 97 POLICY_SOURCE_CLOUD, base::MakeUnique<base::Value>("not visible"),
98 base::MakeUnique<base::StringValue>("not visible"), nullptr); 98 nullptr);
99 mock_provider_.UpdatePolicy(std::move(delegate_bundle)); 99 mock_provider_.UpdatePolicy(std::move(delegate_bundle));
100 Mock::VerifyAndClearExpectations(&observer_); 100 Mock::VerifyAndClearExpectations(&observer_);
101 101
102 EXPECT_FALSE(schema_registry_tracking_provider_.IsInitializationComplete( 102 EXPECT_FALSE(schema_registry_tracking_provider_.IsInitializationComplete(
103 POLICY_DOMAIN_EXTENSIONS)); 103 POLICY_DOMAIN_EXTENSIONS));
104 EXPECT_TRUE(schema_registry_tracking_provider_.policies().Equals(bundle)); 104 EXPECT_TRUE(schema_registry_tracking_provider_.policies().Equals(bundle));
105 } 105 }
106 106
107 TEST_F(SchemaRegistryTrackingPolicyProviderTest, RefreshPolicies) { 107 TEST_F(SchemaRegistryTrackingPolicyProviderTest, RefreshPolicies) {
108 EXPECT_CALL(mock_provider_, RefreshPolicies()); 108 EXPECT_CALL(mock_provider_, RefreshPolicies());
109 schema_registry_tracking_provider_.RefreshPolicies(); 109 schema_registry_tracking_provider_.RefreshPolicies();
110 Mock::VerifyAndClearExpectations(&mock_provider_); 110 Mock::VerifyAndClearExpectations(&mock_provider_);
111 } 111 }
112 112
113 TEST_F(SchemaRegistryTrackingPolicyProviderTest, SchemaReady) { 113 TEST_F(SchemaRegistryTrackingPolicyProviderTest, SchemaReady) {
114 EXPECT_CALL(observer_, OnUpdatePolicy(&schema_registry_tracking_provider_)); 114 EXPECT_CALL(observer_, OnUpdatePolicy(&schema_registry_tracking_provider_));
115 schema_registry_.SetAllDomainsReady(); 115 schema_registry_.SetAllDomainsReady();
116 Mock::VerifyAndClearExpectations(&observer_); 116 Mock::VerifyAndClearExpectations(&observer_);
117 117
118 EXPECT_TRUE(schema_registry_tracking_provider_.IsInitializationComplete( 118 EXPECT_TRUE(schema_registry_tracking_provider_.IsInitializationComplete(
119 policy::POLICY_DOMAIN_EXTENSIONS)); 119 policy::POLICY_DOMAIN_EXTENSIONS));
120 } 120 }
121 121
122 TEST_F(SchemaRegistryTrackingPolicyProviderTest, SchemaReadyWithComponents) { 122 TEST_F(SchemaRegistryTrackingPolicyProviderTest, SchemaReadyWithComponents) {
123 PolicyMap policy_map; 123 PolicyMap policy_map;
124 policy_map.Set("foo", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, 124 policy_map.Set("foo", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
125 POLICY_SOURCE_CLOUD, 125 POLICY_SOURCE_CLOUD, base::MakeUnique<base::Value>("omg"),
126 base::MakeUnique<base::StringValue>("omg"), nullptr); 126 nullptr);
127 std::unique_ptr<PolicyBundle> bundle(new PolicyBundle); 127 std::unique_ptr<PolicyBundle> bundle(new PolicyBundle);
128 bundle->Get(PolicyNamespace(POLICY_DOMAIN_CHROME, "")).CopyFrom(policy_map); 128 bundle->Get(PolicyNamespace(POLICY_DOMAIN_CHROME, "")).CopyFrom(policy_map);
129 bundle->Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, "xyz")) 129 bundle->Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, "xyz"))
130 .CopyFrom(policy_map); 130 .CopyFrom(policy_map);
131 EXPECT_CALL(observer_, OnUpdatePolicy(&schema_registry_tracking_provider_)); 131 EXPECT_CALL(observer_, OnUpdatePolicy(&schema_registry_tracking_provider_));
132 mock_provider_.UpdatePolicy(std::move(bundle)); 132 mock_provider_.UpdatePolicy(std::move(bundle));
133 Mock::VerifyAndClearExpectations(&observer_); 133 Mock::VerifyAndClearExpectations(&observer_);
134 134
135 EXPECT_CALL(mock_provider_, RefreshPolicies()).Times(0); 135 EXPECT_CALL(mock_provider_, RefreshPolicies()).Times(0);
136 schema_registry_.RegisterComponent( 136 schema_registry_.RegisterComponent(
(...skipping 27 matching lines...) Expand all
164 164
165 TEST_F(SchemaRegistryTrackingPolicyProviderTest, DelegateUpdates) { 165 TEST_F(SchemaRegistryTrackingPolicyProviderTest, DelegateUpdates) {
166 schema_registry_.RegisterComponent( 166 schema_registry_.RegisterComponent(
167 PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, "xyz"), CreateTestSchema()); 167 PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, "xyz"), CreateTestSchema());
168 EXPECT_FALSE(schema_registry_.IsReady()); 168 EXPECT_FALSE(schema_registry_.IsReady());
169 EXPECT_FALSE(schema_registry_tracking_provider_.IsInitializationComplete( 169 EXPECT_FALSE(schema_registry_tracking_provider_.IsInitializationComplete(
170 policy::POLICY_DOMAIN_EXTENSIONS)); 170 policy::POLICY_DOMAIN_EXTENSIONS));
171 171
172 PolicyMap policy_map; 172 PolicyMap policy_map;
173 policy_map.Set("foo", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, 173 policy_map.Set("foo", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
174 POLICY_SOURCE_CLOUD, 174 POLICY_SOURCE_CLOUD, base::MakeUnique<base::Value>("omg"),
175 base::MakeUnique<base::StringValue>("omg"), nullptr); 175 nullptr);
176 // Chrome policy updates are visible even if the components aren't ready. 176 // Chrome policy updates are visible even if the components aren't ready.
177 EXPECT_CALL(observer_, OnUpdatePolicy(&schema_registry_tracking_provider_)); 177 EXPECT_CALL(observer_, OnUpdatePolicy(&schema_registry_tracking_provider_));
178 mock_provider_.UpdateChromePolicy(policy_map); 178 mock_provider_.UpdateChromePolicy(policy_map);
179 Mock::VerifyAndClearExpectations(&observer_); 179 Mock::VerifyAndClearExpectations(&observer_);
180 180
181 EXPECT_CALL(mock_provider_, RefreshPolicies()); 181 EXPECT_CALL(mock_provider_, RefreshPolicies());
182 schema_registry_.SetAllDomainsReady(); 182 schema_registry_.SetAllDomainsReady();
183 EXPECT_TRUE(schema_registry_.IsReady()); 183 EXPECT_TRUE(schema_registry_.IsReady());
184 Mock::VerifyAndClearExpectations(&mock_provider_); 184 Mock::VerifyAndClearExpectations(&mock_provider_);
185 EXPECT_FALSE(schema_registry_tracking_provider_.IsInitializationComplete( 185 EXPECT_FALSE(schema_registry_tracking_provider_.IsInitializationComplete(
(...skipping 16 matching lines...) Expand all
202 202
203 TEST_F(SchemaRegistryTrackingPolicyProviderTest, RemoveAndAddComponent) { 203 TEST_F(SchemaRegistryTrackingPolicyProviderTest, RemoveAndAddComponent) {
204 EXPECT_CALL(mock_provider_, RefreshPolicies()); 204 EXPECT_CALL(mock_provider_, RefreshPolicies());
205 const PolicyNamespace ns(POLICY_DOMAIN_EXTENSIONS, "xyz"); 205 const PolicyNamespace ns(POLICY_DOMAIN_EXTENSIONS, "xyz");
206 schema_registry_.RegisterComponent(ns, CreateTestSchema()); 206 schema_registry_.RegisterComponent(ns, CreateTestSchema());
207 schema_registry_.SetAllDomainsReady(); 207 schema_registry_.SetAllDomainsReady();
208 Mock::VerifyAndClearExpectations(&mock_provider_); 208 Mock::VerifyAndClearExpectations(&mock_provider_);
209 209
210 // Serve policy for |ns|. 210 // Serve policy for |ns|.
211 PolicyBundle platform_policy; 211 PolicyBundle platform_policy;
212 platform_policy.Get(ns).Set( 212 platform_policy.Get(ns).Set("foo", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
213 "foo", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD, 213 POLICY_SOURCE_CLOUD,
214 base::MakeUnique<base::StringValue>("omg"), nullptr); 214 base::MakeUnique<base::Value>("omg"), nullptr);
215 std::unique_ptr<PolicyBundle> copy(new PolicyBundle); 215 std::unique_ptr<PolicyBundle> copy(new PolicyBundle);
216 copy->CopyFrom(platform_policy); 216 copy->CopyFrom(platform_policy);
217 EXPECT_CALL(observer_, OnUpdatePolicy(_)); 217 EXPECT_CALL(observer_, OnUpdatePolicy(_));
218 mock_provider_.UpdatePolicy(std::move(copy)); 218 mock_provider_.UpdatePolicy(std::move(copy));
219 Mock::VerifyAndClearExpectations(&observer_); 219 Mock::VerifyAndClearExpectations(&observer_);
220 EXPECT_TRUE( 220 EXPECT_TRUE(
221 schema_registry_tracking_provider_.policies().Equals(platform_policy)); 221 schema_registry_tracking_provider_.policies().Equals(platform_policy));
222 222
223 // Now remove that component. 223 // Now remove that component.
224 EXPECT_CALL(observer_, OnUpdatePolicy(_)); 224 EXPECT_CALL(observer_, OnUpdatePolicy(_));
(...skipping 11 matching lines...) Expand all
236 EXPECT_CALL(observer_, OnUpdatePolicy(_)); 236 EXPECT_CALL(observer_, OnUpdatePolicy(_));
237 copy.reset(new PolicyBundle); 237 copy.reset(new PolicyBundle);
238 copy->CopyFrom(platform_policy); 238 copy->CopyFrom(platform_policy);
239 mock_provider_.UpdatePolicy(std::move(copy)); 239 mock_provider_.UpdatePolicy(std::move(copy));
240 Mock::VerifyAndClearExpectations(&observer_); 240 Mock::VerifyAndClearExpectations(&observer_);
241 EXPECT_TRUE( 241 EXPECT_TRUE(
242 schema_registry_tracking_provider_.policies().Equals(platform_policy)); 242 schema_registry_tracking_provider_.policies().Equals(platform_policy));
243 } 243 }
244 244
245 } // namespace policy 245 } // namespace policy
OLDNEW
« no previous file with comments | « components/policy/core/common/schema_map_unittest.cc ('k') | components/policy/core/common/schema_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698