chrome/browser/ui/webui/media/webrtc_logs_ui.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/media/webrtc_logs_ui.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/media/webrtc_logs_ui.cc

diff --git a/chrome/browser/ui/webui/media/webrtc_logs_ui.cc b/chrome/browser/ui/webui/media/webrtc_logs_ui.cc

index 4ce45f6f8e27fa1aee43ca312f118e72d534bde4..5a3355fbab2631f1725e14f410392e67b6d49af3 100644

--- a/chrome/browser/ui/webui/media/webrtc_logs_ui.cc

+++ b/chrome/browser/ui/webui/media/webrtc_logs_ui.cc

@@ -202,7 +202,7 @@ void WebRtcLogsDOMHandler::UpdateUI() {

upload_list.Append(std::move(upload));

}

- base::StringValue version(version_info::GetVersionNumber());

+ base::Value version(version_info::GetVersionNumber());

web_ui()->CallJavascriptFunctionUnsafe("updateWebRtcLogsList", upload_list,

version);