chrome/browser/extensions/api/media_galleries/media_galleries_api.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/mdns/mdns_api_unittest.cc ('k') | chrome/browser/extensions/api/messaging/message_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

diff --git a/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc b/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

index 57abe0f8b1e474ba4391ba26eb2d4b60999b0d7a..1b9765f27168315369a6e87c3888d0c308321f4f 100644

--- a/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

+++ b/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

@@ -743,10 +743,8 @@ void MediaGalleriesGetMetadataFunction::ConstructNextBlob(

&(*attached_images)[blob_uuids->size()];

std::unique_ptr<base::DictionaryValue> attached_image(

new base::DictionaryValue);

- attached_image->Set(kBlobUUIDKey, new base::StringValue(

- current_blob->GetUUID()));

- attached_image->Set(kTypeKey, new base::StringValue(

- current_image->type));

+ attached_image->Set(kBlobUUIDKey, new base::Value(current_blob->GetUUID()));

+ attached_image->Set(kTypeKey, new base::Value(current_image->type));

attached_image->Set(

kSizeKey,

new base::Value(base::checked_cast<int>(current_image->data.size())));