Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: components/policy/core/common/cloud/cloud_policy_manager_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/cloud/cloud_policy_manager_unittest.cc
diff --git a/components/policy/core/common/cloud/cloud_policy_manager_unittest.cc b/components/policy/core/common/cloud/cloud_policy_manager_unittest.cc
index 836b15c41f215cf16c903236542eb02431570630..ad47f9a97548e4d4f66282e7136ef5bdb6fb9998 100644
--- a/components/policy/core/common/cloud/cloud_policy_manager_unittest.cc
+++ b/components/policy/core/common/cloud/cloud_policy_manager_unittest.cc
@@ -88,9 +88,9 @@ void TestHarness::InstallEmptyPolicy() {}
void TestHarness::InstallStringPolicy(const std::string& policy_name,
const std::string& policy_value) {
- store_.policy_map_.Set(
- policy_name, policy_level(), policy_scope(), POLICY_SOURCE_CLOUD,
- base::MakeUnique<base::StringValue>(policy_value), nullptr);
+ store_.policy_map_.Set(policy_name, policy_level(), policy_scope(),
+ POLICY_SOURCE_CLOUD,
+ base::MakeUnique<base::Value>(policy_value), nullptr);
}
void TestHarness::InstallIntegerPolicy(const std::string& policy_name,
@@ -174,8 +174,8 @@ class CloudPolicyManagerTest : public testing::Test {
void SetUp() override {
// Set up a policy map for testing.
policy_map_.Set("key", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- POLICY_SOURCE_CLOUD,
- base::MakeUnique<base::StringValue>("value"), nullptr);
+ POLICY_SOURCE_CLOUD, base::MakeUnique<base::Value>("value"),
+ nullptr);
expected_bundle_.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))
.CopyFrom(policy_map_);

Powered by Google App Engine
This is Rietveld 408576698