chrome/browser/ui/app_list/start_page_service.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/start_page_service.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/app_list/start_page_service.cc

diff --git a/chrome/browser/ui/app_list/start_page_service.cc b/chrome/browser/ui/app_list/start_page_service.cc

index f75493ab6280310727aeae01bbb597825e8ed8b4..db48a06edca2ed7bef5aa75348f904e99e41a0c7 100644

--- a/chrome/browser/ui/app_list/start_page_service.cc

+++ b/chrome/browser/ui/app_list/start_page_service.cc

@@ -676,8 +676,7 @@ void StartPageService::OnURLFetchComplete(const net::URLFetcher* source) {

if (contents_ && contents_->GetWebUI()) {

contents_->GetWebUI()->CallJavascriptFunctionUnsafe(

"appList.startPage.onAppListDoodleUpdated", *doodle_json,

- base::StringValue(

- UIThreadSearchTermsData(profile_).GoogleBaseURLValue()));

+ base::Value(UIThreadSearchTermsData(profile_).GoogleBaseURLValue()));

}