Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2942)

Unified Diff: chrome/browser/extensions/api/notifications/notifications_api.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/notifications/notifications_api.cc
diff --git a/chrome/browser/extensions/api/notifications/notifications_api.cc b/chrome/browser/extensions/api/notifications/notifications_api.cc
index cd435f5d0c6a9f86bc89245c801e83681d01ccf2..eac302aee574628513c0e7c70ec3fb657f23ff0d 100644
--- a/chrome/browser/extensions/api/notifications/notifications_api.cc
+++ b/chrome/browser/extensions/api/notifications/notifications_api.cc
@@ -704,7 +704,7 @@ bool NotificationsCreateFunction::RunNotificationsApi() {
notification_id = base::RandBytesAsString(16);
}
- SetResult(base::MakeUnique<base::StringValue>(notification_id));
+ SetResult(base::MakeUnique<base::Value>(notification_id));
// TODO(dewittj): Add more human-readable error strings if this fails.
if (!CreateNotification(notification_id, &params_->options))
@@ -817,8 +817,8 @@ bool NotificationsGetPermissionLevelFunction::RunNotificationsApi() {
? api::notifications::PERMISSION_LEVEL_GRANTED
: api::notifications::PERMISSION_LEVEL_DENIED;
- SetResult(base::MakeUnique<base::StringValue>(
- api::notifications::ToString(result)));
+ SetResult(
+ base::MakeUnique<base::Value>(api::notifications::ToString(result)));
SendResponse(true);
return true;

Powered by Google App Engine
This is Rietveld 408576698