Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/json/json_parser.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/json/json_parser.h ('k') | base/json/json_perftest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/json/json_parser.cc
diff --git a/base/json/json_parser.cc b/base/json/json_parser.cc
index 1666c122b1caa3c03cd8e9b3988a5f4ee2496cbc..c6f6409df62b87201207ef993addcb90df6d7187 100644
--- a/base/json/json_parser.cc
+++ b/base/json/json_parser.cc
@@ -444,7 +444,7 @@ std::unique_ptr<Value> JSONParser::ConsumeString() {
if (!ConsumeStringRaw(&string))
return nullptr;
- return base::MakeUnique<StringValue>(string.DestructiveAsString());
+ return base::MakeUnique<Value>(string.DestructiveAsString());
}
bool JSONParser::ConsumeStringRaw(StringBuilder* out) {
« no previous file with comments | « base/json/json_parser.h ('k') | base/json/json_perftest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698