Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3080)

Unified Diff: chrome/browser/ui/webui/options/language_options_handler_common.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/language_options_handler_common.cc
diff --git a/chrome/browser/ui/webui/options/language_options_handler_common.cc b/chrome/browser/ui/webui/options/language_options_handler_common.cc
index 4b6b396d7681a8deabd0ea907868aaff646e8301..c2f6468e75c35f5901826b84edb7b48a33001b19 100644
--- a/chrome/browser/ui/webui/options/language_options_handler_common.cc
+++ b/chrome/browser/ui/webui/options/language_options_handler_common.cc
@@ -166,21 +166,21 @@ void LanguageOptionsHandlerCommon::OnHunspellDictionaryDownloadBegin(
const std::string& language) {
web_ui()->CallJavascriptFunctionUnsafe(
"options.LanguageOptions.onDictionaryDownloadBegin",
- base::StringValue(language));
+ base::Value(language));
}
void LanguageOptionsHandlerCommon::OnHunspellDictionaryDownloadSuccess(
const std::string& language) {
web_ui()->CallJavascriptFunctionUnsafe(
"options.LanguageOptions.onDictionaryDownloadSuccess",
- base::StringValue(language));
+ base::Value(language));
}
void LanguageOptionsHandlerCommon::OnHunspellDictionaryDownloadFailure(
const std::string& language) {
web_ui()->CallJavascriptFunctionUnsafe(
"options.LanguageOptions.onDictionaryDownloadFailure",
- base::StringValue(language));
+ base::Value(language));
}
base::DictionaryValue* LanguageOptionsHandlerCommon::GetUILanguageCodeSet() {
@@ -232,7 +232,7 @@ void LanguageOptionsHandlerCommon::UiLanguageChangeCallback(
"LanguageOptions_UiLanguageChange_%s", language_code.c_str());
content::RecordComputedAction(action);
SetApplicationLocale(language_code);
- base::StringValue language_value(language_code);
+ base::Value language_value(language_code);
web_ui()->CallJavascriptFunctionUnsafe(
"options.LanguageOptions.uiLanguageSaved", language_value);
}
« no previous file with comments | « chrome/browser/ui/webui/options/font_settings_handler.cc ('k') | chrome/browser/ui/webui/options/manage_profile_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698