Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
diff --git a/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc b/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
index f114a1739679b7f0045a26affc9344e4bb4f2b88..77de1286236cd715835c02ffeca5618ca3ba0608 100644
--- a/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
+++ b/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
@@ -115,17 +115,16 @@ void OfflineInternalsUIMessageHandler::HandleDeleteSelectedRequests(
void OfflineInternalsUIMessageHandler::HandleDeletedPagesCallback(
std::string callback_id,
offline_pages::DeletePageResult result) {
- ResolveJavascriptCallback(
- base::StringValue(callback_id),
- base::StringValue(GetStringFromDeletePageResult(result)));
+ ResolveJavascriptCallback(base::Value(callback_id),
+ base::Value(GetStringFromDeletePageResult(result)));
}
void OfflineInternalsUIMessageHandler::HandleDeletedRequestsCallback(
std::string callback_id,
const offline_pages::MultipleItemStatuses& results) {
ResolveJavascriptCallback(
- base::StringValue(callback_id),
- base::StringValue(GetStringFromDeleteRequestResults(results)));
+ base::Value(callback_id),
+ base::Value(GetStringFromDeleteRequestResults(results)));
}
void OfflineInternalsUIMessageHandler::HandleStoredPagesCallback(
@@ -146,7 +145,7 @@ void OfflineInternalsUIMessageHandler::HandleStoredPagesCallback(
offline_page->SetInteger("accessCount", page.access_count);
offline_page->SetString("originalUrl", page.original_url.spec());
}
- ResolveJavascriptCallback(base::StringValue(callback_id), results);
+ ResolveJavascriptCallback(base::Value(callback_id), results);
}
void OfflineInternalsUIMessageHandler::HandleRequestQueueCallback(
@@ -171,7 +170,7 @@ void OfflineInternalsUIMessageHandler::HandleRequestQueueCallback(
request->original_url().spec());
}
}
- ResolveJavascriptCallback(base::StringValue(callback_id), save_page_requests);
+ ResolveJavascriptCallback(base::Value(callback_id), save_page_requests);
}
void OfflineInternalsUIMessageHandler::HandleGetRequestQueue(
@@ -186,7 +185,7 @@ void OfflineInternalsUIMessageHandler::HandleGetRequestQueue(
weak_ptr_factory_.GetWeakPtr(), callback_id));
} else {
base::ListValue results;
- ResolveJavascriptCallback(base::StringValue(callback_id), results);
+ ResolveJavascriptCallback(base::Value(callback_id), results);
}
}
@@ -202,7 +201,7 @@ void OfflineInternalsUIMessageHandler::HandleGetStoredPages(
weak_ptr_factory_.GetWeakPtr(), callback_id));
} else {
base::ListValue results;
- ResolveJavascriptCallback(base::StringValue(callback_id), results);
+ ResolveJavascriptCallback(base::Value(callback_id), results);
}
}
@@ -221,8 +220,8 @@ void OfflineInternalsUIMessageHandler::HandleGetNetworkStatus(
ResolveJavascriptCallback(
*callback_id,
- base::StringValue(net::NetworkChangeNotifier::IsOffline() ? "Offline"
- : "Online"));
+ base::Value(net::NetworkChangeNotifier::IsOffline() ? "Offline"
+ : "Online"));
}
void OfflineInternalsUIMessageHandler::HandleSetRecordRequestQueue(
« no previous file with comments | « chrome/browser/ui/webui/ntp/new_tab_ui.cc ('k') | chrome/browser/ui/webui/options/browser_options_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698