Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3992)

Unified Diff: chrome/browser/extensions/chrome_app_sorting.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/chrome_app_sorting.cc
diff --git a/chrome/browser/extensions/chrome_app_sorting.cc b/chrome/browser/extensions/chrome_app_sorting.cc
index 81f9ef5fc9948cad0185cbf775a33b96d3d4c9d4..c9245134a461ec8aa9666210508a58ec9aa717aa 100644
--- a/chrome/browser/extensions/chrome_app_sorting.cc
+++ b/chrome/browser/extensions/chrome_app_sorting.cc
@@ -321,9 +321,10 @@ void ChromeAppSorting::SetAppLaunchOrdinal(
extension_id, page_ordinal, GetAppLaunchOrdinal(extension_id));
AddOrdinalMapping(extension_id, page_ordinal, new_app_launch_ordinal);
- base::Value* new_value = new_app_launch_ordinal.IsValid() ?
- new base::StringValue(new_app_launch_ordinal.ToInternalValue()) :
- NULL;
+ base::Value* new_value =
+ new_app_launch_ordinal.IsValid()
+ ? new base::Value(new_app_launch_ordinal.ToInternalValue())
+ : NULL;
ExtensionPrefs::Get(browser_context_)->UpdateExtensionPref(
extension_id,
@@ -400,9 +401,10 @@ void ChromeAppSorting::SetPageOrdinal(
extension_id, GetPageOrdinal(extension_id), app_launch_ordinal);
AddOrdinalMapping(extension_id, new_page_ordinal, app_launch_ordinal);
- base::Value* new_value = new_page_ordinal.IsValid() ?
- new base::StringValue(new_page_ordinal.ToInternalValue()) :
- NULL;
+ base::Value* new_value =
+ new_page_ordinal.IsValid()
+ ? new base::Value(new_page_ordinal.ToInternalValue())
+ : NULL;
ExtensionPrefs::Get(browser_context_)->UpdateExtensionPref(
extension_id,

Powered by Google App Engine
This is Rietveld 408576698