Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4594)

Unified Diff: chrome/test/chromedriver/chrome/log.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/alert_commands.cc ('k') | chrome/test/chromedriver/commands.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/log.cc
diff --git a/chrome/test/chromedriver/chrome/log.cc b/chrome/test/chromedriver/chrome/log.cc
index c98ab48dfa5aa35e3453048fd74d0f5940e3d740..93024c02e88ccb1f2cb7e1244c0e26247381383a 100644
--- a/chrome/test/chromedriver/chrome/log.cc
+++ b/chrome/test/chromedriver/chrome/log.cc
@@ -72,7 +72,7 @@ std::unique_ptr<base::Value> SmartDeepCopy(const base::Value* value) {
return std::move(list_copy);
} else if (value->GetAsString(&data)) {
TruncateString(&data);
- return std::unique_ptr<base::Value>(new base::StringValue(data));
+ return std::unique_ptr<base::Value>(new base::Value(data));
}
return std::unique_ptr<base::Value>(value->DeepCopy());
}
@@ -110,6 +110,6 @@ std::string FormatValueForDisplay(const base::Value& value) {
std::string FormatJsonForDisplay(const std::string& json) {
std::unique_ptr<base::Value> value = base::JSONReader::Read(json);
if (!value)
- value.reset(new base::StringValue(json));
+ value.reset(new base::Value(json));
return FormatValueForDisplay(*value);
}
« no previous file with comments | « chrome/test/chromedriver/alert_commands.cc ('k') | chrome/test/chromedriver/commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698