ios/chrome/browser/ui/reader_mode/reader_mode_checker.mm - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/reader_mode/reader_mode_checker.mm

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/reader_mode/reader_mode_checker.mm

diff --git a/ios/chrome/browser/ui/reader_mode/reader_mode_checker.mm b/ios/chrome/browser/ui/reader_mode/reader_mode_checker.mm

index d2ccabaaa908727bd54b93db76b0463697e8d44d..8c207d6ca7da7b37249a9866cdd8fd7dfea9407a 100644

--- a/ios/chrome/browser/ui/reader_mode/reader_mode_checker.mm

+++ b/ios/chrome/browser/ui/reader_mode/reader_mode_checker.mm

@@ -118,7 +118,7 @@ void ReaderModeChecker::CheckIsDistillableDetector(

}

const dom_distiller::DistillablePageDetector* detector =

dom_distiller::DistillablePageDetector::GetDefault();

- const base::StringValue value(base::SysNSStringToUTF8(result));

+ const base::Value value(base::SysNSStringToUTF8(result));

std::vector<double> features(

dom_distiller::CalculateDerivedFeaturesFromJSON(&value));

if (detector->Classify(features)) {