Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5893)

Unified Diff: chromeos/network/onc/onc_translator_onc_to_shill.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/onc/onc_translator_onc_to_shill.cc
diff --git a/chromeos/network/onc/onc_translator_onc_to_shill.cc b/chromeos/network/onc/onc_translator_onc_to_shill.cc
index 606fe322bb78fdf8ffc9017228efe19a005b7c4c..39e75c9a8ff00c81ab1bb75cfcd3929e4020c973 100644
--- a/chromeos/network/onc/onc_translator_onc_to_shill.cc
+++ b/chromeos/network/onc/onc_translator_onc_to_shill.cc
@@ -31,12 +31,11 @@ namespace onc {
namespace {
-std::unique_ptr<base::StringValue> ConvertValueToString(
- const base::Value& value) {
+std::unique_ptr<base::Value> ConvertValueToString(const base::Value& value) {
std::string str;
if (!value.GetAsString(&str))
base::JSONWriter::Write(value, &str);
- return base::MakeUnique<base::StringValue>(str);
+ return base::MakeUnique<base::Value>(str);
}
// This class is responsible to translate the local fields of the given
« no previous file with comments | « chromeos/network/network_state_handler_unittest.cc ('k') | chromeos/network/onc/onc_translator_shill_to_onc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698