chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc ('k') | chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc

index 73df7234e789e3253f3f32d952746ec3218fc260..d1796b121325d7b2f7d146b0c00553fa424c065e 100644

--- a/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc

+++ b/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc

@@ -285,7 +285,7 @@ void ChangePictureOptionsHandler::SendSelectedImage() {

if (previous_image_index_ >=

default_user_image::kFirstDefaultImageIndex) {

// User has image from the current set of default images.

- base::StringValue image_url(

+ base::Value image_url(

default_user_image::GetDefaultImageUrl(previous_image_index_));

web_ui()->CallJavascriptFunctionUnsafe(

"ChangePictureOptions.setSelectedImage", image_url);

@@ -301,7 +301,7 @@ void ChangePictureOptionsHandler::SendSelectedImage() {

void ChangePictureOptionsHandler::SendProfileImage(const gfx::ImageSkia& image,

bool should_select) {

- base::StringValue data_url(webui::GetBitmapDataUrl(*image.bitmap()));

+ base::Value data_url(webui::GetBitmapDataUrl(*image.bitmap()));

base::Value select(should_select);

web_ui()->CallJavascriptFunctionUnsafe("ChangePictureOptions.setProfileImage",

data_url, select);

@@ -321,7 +321,7 @@ void ChangePictureOptionsHandler::UpdateProfileImage() {

void ChangePictureOptionsHandler::SendOldImage(const std::string& image_url) {

previous_image_url_ = image_url;

- base::StringValue url(image_url);

+ base::Value url(image_url);

web_ui()->CallJavascriptFunctionUnsafe("ChangePictureOptions.setOldImage",

url);

}