chrome/browser/extensions/api/module/module.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/module/module.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/module/module.cc

diff --git a/chrome/browser/extensions/api/module/module.cc b/chrome/browser/extensions/api/module/module.cc

index 8c575be5854a6eac65e504ca8cd87ea89c4bb715..2cec9509a59674fa6e720a9f7b11186ecff06909 100644

--- a/chrome/browser/extensions/api/module/module.cc

+++ b/chrome/browser/extensions/api/module/module.cc

@@ -47,7 +47,7 @@ ExtensionFunction::ResponseAction ExtensionSetUpdateUrlDataFunction::Run() {

ExtensionPrefs::Get(browser_context())

->UpdateExtensionPref(extension_id(), extension::kUpdateURLData,

- new base::StringValue(data));

+ new base::Value(data));

return RespondNow(NoArguments());

}