extensions/common/extension_l10n_util.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/extension_l10n_util.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/extension_l10n_util.cc

diff --git a/extensions/common/extension_l10n_util.cc b/extensions/common/extension_l10n_util.cc

index bf0194a4f6c409b115dfd7908337cb0c8b6567c9..4422ca344d260bc504df2fb0694e71943b11c6b0 100644

--- a/extensions/common/extension_l10n_util.cc

+++ b/extensions/common/extension_l10n_util.cc

@@ -92,7 +92,7 @@ bool LocalizeManifestListValue(const std::string& key,

std::string result;

if (list->GetString(i, &result)) {

if (messages.ReplaceMessages(&result, error))

- list->Set(i, new base::StringValue(result));

+ list->Set(i, new base::Value(result));

else

ret = false;

}