Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2536943003: Upstream all iOS-only localized strings and their translation. (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream all iOS-only localized strings and their translation. The upstreaming has been automated and the .grd file automatically modified to ensure that the entries are in alphabetical order. As this made the comments incorrects, they have been removed too. BUG=None Committed: https://crrev.com/cc9890fd0fc8431b1462b191b5306b25a45c29fa Cr-Commit-Position: refs/heads/master@{#435219}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23259 lines, -129 lines) Patch
M ios/chrome/app/strings/ios_chromium_strings.grd View 1 2 3 chunks +129 lines, -16 lines 0 comments Download
M ios/chrome/app/strings/ios_google_chrome_strings.grd View 1 2 3 chunks +128 lines, -15 lines 0 comments Download
M ios/chrome/app/strings/ios_strings.grd View 1 2 3 chunks +1318 lines, -97 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_am.xtb View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_ar.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_bg.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_bn.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_ca.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_cs.xtb View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_da.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_de.xtb View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_el.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_en-GB.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_es.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_es-419.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_et.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_fa.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_fi.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_fil.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_fr.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_gu.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_hi.xtb View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_hr.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_hu.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_id.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_it.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_iw.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_ja.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_kn.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_ko.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_lt.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_lv.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_ml.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_mr.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_ms.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_nl.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_no.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_pl.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_pt-BR.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_pt-PT.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_ro.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_ru.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_sk.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_sl.xtb View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_sr.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_sv.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_sw.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_ta.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_te.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_th.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_tr.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_uk.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_vi.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_zh-CN.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_chromium_strings_zh-TW.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_am.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_ar.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_bg.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_bn.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_ca.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_cs.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_da.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_de.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_el.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_en-GB.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_es.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_es-419.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_et.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_fa.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_fi.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_fil.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_fr.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_gu.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_hi.xtb View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_hr.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_hu.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_id.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_it.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_iw.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_ja.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_kn.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_ko.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_lt.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_lv.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_ml.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_mr.xtb View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_ms.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_nl.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_no.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_pl.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_pt-BR.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_pt-PT.xtb View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_ro.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_ru.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_sk.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_sl.xtb View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_sr.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_sv.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_sw.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_ta.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_te.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_th.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_tr.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_uk.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_vi.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_zh-CN.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_google_chrome_strings_zh-TW.xtb View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_am.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_ar.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_bg.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_bn.xtb View 1 2 1 chunk +348 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_ca.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_cs.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_da.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_de.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_el.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_en-GB.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_es.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_es-419.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_et.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_fa.xtb View 1 2 1 chunk +348 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_fi.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_fil.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_fr.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_gu.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_hi.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_hr.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_hu.xtb View 1 2 1 chunk +348 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_id.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_it.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_iw.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_ja.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_kn.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_ko.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_lt.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_lv.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_ml.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_mr.xtb View 1 2 1 chunk +348 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_ms.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_nl.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_no.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_pl.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_pt-BR.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_pt-PT.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_ro.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_ru.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_sk.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_sl.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_sr.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_sv.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_sw.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_ta.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_te.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_th.xtb View 1 2 1 chunk +346 lines, -1 line 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_tr.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_uk.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_vi.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_zh-CN.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/resources/ios_strings_zh-TW.xtb View 1 2 1 chunk +347 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (22 generated)
rohitrao (ping after 24h)
Rubberstamp LGTM https://codereview.chromium.org/2536943003/diff/50001/ios/chrome/app/strings/ios_chromium_strings.grd File ios/chrome/app/strings/ios_chromium_strings.grd (right): https://codereview.chromium.org/2536943003/diff/50001/ios/chrome/app/strings/ios_chromium_strings.grd#newcode144 ios/chrome/app/strings/ios_chromium_strings.grd:144: Copied to Chrome Oops. (Not in scope ...
4 years ago (2016-11-29 16:08:37 UTC) #8
sdefresne
Thank you for the review. https://codereview.chromium.org/2536943003/diff/50001/ios/chrome/app/strings/ios_chromium_strings.grd File ios/chrome/app/strings/ios_chromium_strings.grd (right): https://codereview.chromium.org/2536943003/diff/50001/ios/chrome/app/strings/ios_chromium_strings.grd#newcode144 ios/chrome/app/strings/ios_chromium_strings.grd:144: Copied to Chrome On ...
4 years ago (2016-11-29 16:32:59 UTC) #11
rohitrao (ping after 24h)
(Reminder to CQ this before you leave, if you intend to land it today.)
4 years ago (2016-11-29 18:52:27 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536943003/60001
4 years ago (2016-11-30 08:40:42 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/315228)
4 years ago (2016-11-30 08:55:17 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536943003/70001
4 years ago (2016-11-30 11:17:03 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:70001)
4 years ago (2016-11-30 11:30:56 UTC) #28
commit-bot: I haz the power
4 years ago (2016-11-30 11:32:59 UTC) #30
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cc9890fd0fc8431b1462b191b5306b25a45c29fa
Cr-Commit-Position: refs/heads/master@{#435219}

Powered by Google App Engine
This is Rietveld 408576698