Convert WindowOpenDisposition to an enum class.

Convert WindowOpenDisposition to an enum class.

This is done in preparation for mojoifying this enum; mojo only generates 'enum class' enums.

TBR=jam@chromium.org
BUG=627852
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/3b04f32172f0e32b249c7d8b6592ccc542bf6511
Cr-Commit-Position: refs/heads/master@{#415722}

[ncarter (slow), 2016-08-15 21:26:54]

Description was changed from

==========
Convert WindowOpenDisposition to an enum class.

BUG=None
==========

to

==========
Convert WindowOpenDisposition to an enum class.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[ncarter (slow), 2016-08-15 22:13:01]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 22:13:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 22:17:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 22:17:38]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[ncarter (slow), 2016-08-15 22:22:21]

Description was changed from

==========
Convert WindowOpenDisposition to an enum class.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Convert WindowOpenDisposition to an enum class.

This is done in preparation for mojoifying this enum; mojo only generates 'enum
class' enums.

BUG=627852
==========

[ncarter (slow), 2016-08-15 22:22:21]

Description was changed from

==========
Convert WindowOpenDisposition to an enum class.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Convert WindowOpenDisposition to an enum class.

This is done in preparation for mojoifying this enum; mojo only generates 'enum
class' enums.

BUG=627852
==========

[ncarter (slow), 2016-08-15 23:16:50]

Description was changed from

==========
Convert WindowOpenDisposition to an enum class.

This is done in preparation for mojoifying this enum; mojo only generates 'enum
class' enums.

BUG=627852
==========

to

==========
Convert WindowOpenDisposition to an enum class.

This is done in preparation for mojoifying this enum; mojo only generates 'enum
class' enums.

BUG=627852
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[ncarter (slow), 2016-08-15 23:17:30]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 23:17:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 23:35:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 23:35:25]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[ncarter (slow), 2016-08-16 16:27:01]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 16:27:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 16:42:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 16:42:06]

Dry run: Exceeded global retry quota

[ncarter (slow), 2016-08-16 16:56:10]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 16:56:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 17:09:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 17:09:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ncarter (slow), 2016-08-16 19:13:47]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 19:14:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ncarter (slow), 2016-08-16 19:38:38]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 19:38:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 19:45:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 19:45:27]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ncarter (slow), 2016-08-16 20:47:32]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 20:48:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 21:11:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 21:11:43]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[ncarter (slow), 2016-08-16 21:15:57]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 21:16:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 21:39:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 21:39:55]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[ncarter (slow), 2016-08-16 21:44:40]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 21:45:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 22:07:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 22:07:24]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[ncarter (slow), 2016-08-29 19:01:11]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 19:09:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ncarter (slow), 2016-08-29 21:36:20]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[ncarter (slow), 2016-08-29 21:58:59]

nick@chromium.org changed reviewers:
+ jam@chromium.org

[ncarter (slow), 2016-08-29 21:59:03]

jam: this is a boring but sweeping change; I'm hoping to use you as top-level
reviewer to avoid looping in lots of individual directory reviewers.

[commit-bot: I haz the power, 2016-08-29 22:14:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ncarter (slow), 2016-08-29 23:20:36]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 23:47:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:20:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:20:54]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jam, 2016-08-30 16:39:28]

On 2016/08/29 21:59:03, ncarter wrote:
> jam: this is a boring but sweeping change; I'm hoping to use you as top-level
> reviewer to avoid looping in lots of individual directory reviewers.

per
https://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Review...,
"For widespread or refactoring changes that are mechanical or global in nature,
it is acceptable to TBR the OWNERS required for submission, as long as your
changes have had the appropriate level of review or general approval.  (For
example, if touching hundreds of files across the codebase, a thread on the
chromium-dev mailing list may be better than getting individual approval from
dozens of different OWNERS.)"

so just get a reviewer for ui/ and TBR the rest

[ncarter (slow), 2016-08-30 18:12:13]

nick@chromium.org changed reviewers:
+ thakis@chromium.org
- jam@chromium.org

[ncarter (slow), 2016-08-30 18:12:15]

Hi Niko,

Could you review the changes in ui/?

Everything else is simply adding static_cast<int>()'s or
WindowOpenDisposition::'s. I've done a thorough self-review to make sure I
didn't change any values by accident; my plan is to TBR the rest.

[Nico, 2016-08-30 18:18:40]

ui/ lgtm if the answer below is "yes"

https://codereview.chromium.org/2248873002/diff/280001/ui/base/window_open_di...
File ui/base/window_open_disposition.h (right):

https://codereview.chromium.org/2248873002/diff/280001/ui/base/window_open_di...
ui/base/window_open_disposition.h:11: // GENERATED_JAVA_ENUM_PACKAGE:
org.chromium.ui
does GENERATED_JAVA_ENUM_PACKAGE work with enum class?

[ncarter (slow), 2016-08-30 18:31:06]

Description was changed from

==========
Convert WindowOpenDisposition to an enum class.

This is done in preparation for mojoifying this enum; mojo only generates 'enum
class' enums.

BUG=627852
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Convert WindowOpenDisposition to an enum class.

This is done in preparation for mojoifying this enum; mojo only generates 'enum
class' enums.

TBR=jam@chromium.org
BUG=627852
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[ncarter (slow), 2016-08-30 20:36:49]

The CQ bit was checked by nick@chromium.org

[ncarter (slow), 2016-08-30 20:36:51]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2248873002/#ps300001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-08-30 20:37:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 20:49:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 20:49:18]

Exceeded global retry quota

[ncarter (slow), 2016-08-30 23:32:22]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 23:33:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 23:41:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 23:41:09]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[ncarter (slow), 2016-08-31 17:00:10]

https://codereview.chromium.org/2248873002/diff/280001/ui/base/window_open_di...
File ui/base/window_open_disposition.h (right):

https://codereview.chromium.org/2248873002/diff/280001/ui/base/window_open_di...
ui/base/window_open_disposition.h:11: // GENERATED_JAVA_ENUM_PACKAGE:
org.chromium.ui
On 2016/08/30 18:18:39, Nico wrote:
> does GENERATED_JAVA_ENUM_PACKAGE work with enum class?

Yes, it works (it works with enum struct, too). This compiles on a clean android
build.

[ncarter (slow), 2016-08-31 17:00:40]

The CQ bit was checked by nick@chromium.org

[ncarter (slow), 2016-08-31 17:00:43]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2248873002/#ps340001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-08-31 17:01:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 19:29:39]

Description was changed from

==========
Convert WindowOpenDisposition to an enum class.

This is done in preparation for mojoifying this enum; mojo only generates 'enum
class' enums.

TBR=jam@chromium.org
BUG=627852
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Convert WindowOpenDisposition to an enum class.

This is done in preparation for mojoifying this enum; mojo only generates 'enum
class' enums.

TBR=jam@chromium.org
BUG=627852
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-08-31 19:29:43]

Committed patchset #18 (id:340001)

[commit-bot: I haz the power, 2016-08-31 19:33:16]

Description was changed from

==========
Convert WindowOpenDisposition to an enum class.

This is done in preparation for mojoifying this enum; mojo only generates 'enum
class' enums.

TBR=jam@chromium.org
BUG=627852
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Convert WindowOpenDisposition to an enum class.

This is done in preparation for mojoifying this enum; mojo only generates 'enum
class' enums.

TBR=jam@chromium.org
BUG=627852
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/3b04f32172f0e32b249c7d8b6592ccc542bf6511
Cr-Commit-Position: refs/heads/master@{#415722}
==========

[commit-bot: I haz the power, 2016-08-31 19:33:21]

Patchset 18 (id:??) landed as
https://crrev.com/3b04f32172f0e32b249c7d8b6592ccc542bf6511
Cr-Commit-Position: refs/heads/master@{#415722}