chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

diff --git a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

index f73984cad6b2ecaccf852e6fd72c66a3e6245055..4253caaaf19e16b453b294155a9835eaf6e037a3 100644

--- a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

+++ b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

@@ -352,10 +352,10 @@ void BrowserTabStripController::PerformDrop(bool drop_before,

if (drop_before) {

content::RecordAction(UserMetricsAction("Tab_DropURLBetweenTabs"));

- params.disposition = NEW_FOREGROUND_TAB;

+ params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;

} else {

content::RecordAction(UserMetricsAction("Tab_DropURLOnTab"));

- params.disposition = CURRENT_TAB;

+ params.disposition = WindowOpenDisposition::CURRENT_TAB;

params.source_contents = model_->GetWebContentsAt(index);

}

params.window_action = chrome::NavigateParams::SHOW_WINDOW;