chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/extensions/extension_installed_notification.cc ('k') | chrome/browser/ui/extensions/hosted_app_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc

diff --git a/chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc b/chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc

index 35dec77a3f82d5691937432f1e75a090a3b6698f..228378069309504395bd2b2c2d49711fd1854983 100644

--- a/chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc

+++ b/chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc

@@ -222,8 +222,8 @@ void ExtensionMessageBubbleBrowserTest::TestControlledHomeBubbleShown() {

CheckBubbleIsNotPresent(browser(), false, false);

- chrome::ExecuteCommandWithDisposition(browser(),

- IDC_HOME, NEW_FOREGROUND_TAB);

+ chrome::ExecuteCommandWithDisposition(

+ browser(), IDC_HOME, WindowOpenDisposition::NEW_FOREGROUND_TAB);

base::RunLoop().RunUntilIdle();

CheckBubble(browser(), ANCHOR_BROWSER_ACTION, false);

@@ -249,7 +249,7 @@ void ExtensionMessageBubbleBrowserTest::TestControlledSearchBubbleShown() {

omnibox->OnBeforePossibleChange();

omnibox->SetUserText(base::ASCIIToUTF16("search for this"));

omnibox->OnAfterPossibleChange(true);

- omnibox->model()->AcceptInput(CURRENT_TAB, false);

+ omnibox->model()->AcceptInput(WindowOpenDisposition::CURRENT_TAB, false);

base::RunLoop().RunUntilIdle();

CheckBubble(browser(), ANCHOR_BROWSER_ACTION, false);