chrome/browser/signin/chrome_signin_helper.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/chrome_signin_helper.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/signin/chrome_signin_helper.cc

diff --git a/chrome/browser/signin/chrome_signin_helper.cc b/chrome/browser/signin/chrome_signin_helper.cc

index 6787db2f6026f1d4c358474b069de8e7e694bf78..118d9c8728d39d464bcd850abf325ab2c616c6c6 100644

--- a/chrome/browser/signin/chrome_signin_helper.cc

+++ b/chrome/browser/signin/chrome_signin_helper.cc

@@ -84,9 +84,9 @@ void ProcessMirrorHeaderUIThread(int child_id,

GURL url(manage_accounts_params.continue_url.empty()

? chrome::kChromeUINativeNewTabURL

: manage_accounts_params.continue_url);

- web_contents->OpenURL(

- content::OpenURLParams(url, content::Referrer(), OFF_THE_RECORD,

- ui::PAGE_TRANSITION_AUTO_TOPLEVEL, false));

+ web_contents->OpenURL(content::OpenURLParams(

+ url, content::Referrer(), WindowOpenDisposition::OFF_THE_RECORD,

+ ui::PAGE_TRANSITION_AUTO_TOPLEVEL, false));

} else {

signin_metrics::LogAccountReconcilorStateOnGaiaResponse(

account_reconcilor->GetState());