chrome/browser/printing/print_dialog_cloud.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/printing/print_dialog_cloud.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/printing/cloud_print/privet_notifications.cc ('k') | chrome/browser/printing/print_dialog_cloud_win.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/printing/print_dialog_cloud.h"	5 #include "chrome/browser/printing/print_dialog_cloud.h"

6	6

7 #include "base/bind.h"	7 #include "base/bind.h"

8 #include "base/macros.h"	8 #include "base/macros.h"

9 #include "base/threading/thread_task_runner_handle.h"	9 #include "base/threading/thread_task_runner_handle.h"

10 #include "chrome/browser/browser_process.h"	10 #include "chrome/browser/browser_process.h"

(...skipping 62 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
73 : BrowserWindow::AVATAR_BUBBLE_MODE_SIGNIN,	73 : BrowserWindow::AVATAR_BUBBLE_MODE_SIGNIN,

74 signin::ManageAccountsParams(),	74 signin::ManageAccountsParams(),

75 signin_metrics::AccessPoint::ACCESS_POINT_CLOUD_PRINT);	75 signin_metrics::AccessPoint::ACCESS_POINT_CLOUD_PRINT);

76 } else {	76 } else {

77 GURL url = add_account ? cloud_devices::GetCloudPrintAddAccountURL()	77 GURL url = add_account ? cloud_devices::GetCloudPrintAddAccountURL()

78 : cloud_devices::GetCloudPrintSigninURL();	78 : cloud_devices::GetCloudPrintSigninURL();

79 content::WebContents* web_contents =	79 content::WebContents* web_contents =

80 browser->OpenURL(content::OpenURLParams(	80 browser->OpenURL(content::OpenURLParams(

81 google_util::AppendGoogleLocaleParam(	81 google_util::AppendGoogleLocaleParam(

82 url, g_browser_process->GetApplicationLocale()),	82 url, g_browser_process->GetApplicationLocale()),

83 content::Referrer(),	83 content::Referrer(), WindowOpenDisposition::NEW_FOREGROUND_TAB,

84 NEW_FOREGROUND_TAB,	84 ui::PAGE_TRANSITION_AUTO_BOOKMARK, false));

85 ui::PAGE_TRANSITION_AUTO_BOOKMARK,

86 false));

87 new SignInObserver(web_contents, callback);	85 new SignInObserver(web_contents, callback);

88 }	86 }

89 }	87 }

90	88

91 } // namespace print_dialog_cloud	89 } // namespace print_dialog_cloud

OLD	NEW