chrome/browser/lifetime/browser_close_manager_browsertest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/lifetime/browser_close_manager_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/interstitials/chrome_controller_client.cc ('k') | chrome/browser/media/defer_background_media_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/lifetime/browser_close_manager_browsertest.cc

diff --git a/chrome/browser/lifetime/browser_close_manager_browsertest.cc b/chrome/browser/lifetime/browser_close_manager_browsertest.cc

index 143c80567fcedfbcfd07bb5f977b679b926d338b..e536bca489260520917ef9a84449b4fbfea573d7 100644

--- a/chrome/browser/lifetime/browser_close_manager_browsertest.cc

+++ b/chrome/browser/lifetime/browser_close_manager_browsertest.cc

@@ -245,9 +245,8 @@ class BrowserCloseManagerBrowserTest

content::DownloadTestObserverInProgress observer(

content::BrowserContext::GetDownloadManager(browser->profile()), 1);

ui_test_utils::NavigateToURLWithDisposition(

- browser,

- GURL(net::URLRequestSlowDownloadJob::kKnownSizeUrl),

- NEW_BACKGROUND_TAB,

+ browser, GURL(net::URLRequestSlowDownloadJob::kKnownSizeUrl),

+ WindowOpenDisposition::NEW_BACKGROUND_TAB,

ui_test_utils::BROWSER_TEST_NONE);

observer.WaitForFinished();

EXPECT_EQ(

@@ -343,11 +342,9 @@ IN_PROC_BROWSER_TEST_P(BrowserCloseManagerBrowserTest,

->CloseWebContentsAt(1, TabStripModel::CLOSE_USER_GESTURE);

content::TestNavigationObserver navigation_observer(

browser()->tab_strip_model()->GetActiveWebContents(), 1);

- ASSERT_NO_FATAL_FAILURE(

- NavigateToURLWithDisposition(browser(),

- GURL(chrome::kChromeUIVersionURL),

- CURRENT_TAB,

- ui_test_utils::BROWSER_TEST_NONE));

+ ASSERT_NO_FATAL_FAILURE(NavigateToURLWithDisposition(

+ browser(), GURL(chrome::kChromeUIVersionURL),

+ WindowOpenDisposition::CURRENT_TAB, ui_test_utils::BROWSER_TEST_NONE));

ASSERT_NO_FATAL_FAILURE(AcceptClose());

navigation_observer.Wait();

@@ -890,9 +887,7 @@ IN_PROC_BROWSER_TEST_P(BrowserCloseManagerWithDownloadsBrowserTest,

content::DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_QUIT);

ui_test_utils::NavigateToURLWithDisposition(

- browser(),

- GURL(download_url),

- NEW_BACKGROUND_TAB,

+ browser(), GURL(download_url), WindowOpenDisposition::NEW_BACKGROUND_TAB,

ui_test_utils::BROWSER_TEST_NONE);

observer.WaitForFinished();