Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: chrome/browser/autofill/content_autofill_driver_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "base/memory/ref_counted.h" 6 #include "base/memory/ref_counted.h"
7 #include "chrome/browser/browser_process.h" 7 #include "chrome/browser/browser_process.h"
8 #include "chrome/browser/ui/browser.h" 8 #include "chrome/browser/ui/browser.h"
9 #include "chrome/browser/ui/browser_tabstrip.h" 9 #include "chrome/browser/ui/browser_tabstrip.h"
10 #include "chrome/browser/ui/tabs/tab_strip_model.h" 10 #include "chrome/browser/ui/tabs/tab_strip_model.h"
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 129
130 IN_PROC_BROWSER_TEST_F(ContentAutofillDriverBrowserTest, 130 IN_PROC_BROWSER_TEST_F(ContentAutofillDriverBrowserTest,
131 TestPageNavigationHidingAutofillPopup) { 131 TestPageNavigationHidingAutofillPopup) {
132 // Notification is different on platforms. On linux this will be called twice, 132 // Notification is different on platforms. On linux this will be called twice,
133 // while on windows only once. 133 // while on windows only once.
134 EXPECT_CALL(autofill_client_, HideAutofillPopup()).Times(testing::AtLeast(1)); 134 EXPECT_CALL(autofill_client_, HideAutofillPopup()).Times(testing::AtLeast(1));
135 135
136 scoped_refptr<content::MessageLoopRunner> runner = 136 scoped_refptr<content::MessageLoopRunner> runner =
137 new content::MessageLoopRunner; 137 new content::MessageLoopRunner;
138 nav_entry_committed_callback_ = runner->QuitClosure(); 138 nav_entry_committed_callback_ = runner->QuitClosure();
139 browser()->OpenURL(content::OpenURLParams(GURL(chrome::kChromeUIBookmarksURL), 139 browser()->OpenURL(content::OpenURLParams(
140 content::Referrer(), 140 GURL(chrome::kChromeUIBookmarksURL), content::Referrer(),
141 CURRENT_TAB, 141 WindowOpenDisposition::CURRENT_TAB, ui::PAGE_TRANSITION_TYPED, false));
142 ui::PAGE_TRANSITION_TYPED, 142 browser()->OpenURL(content::OpenURLParams(
143 false)); 143 GURL(chrome::kChromeUIAboutURL), content::Referrer(),
144 browser()->OpenURL(content::OpenURLParams(GURL(chrome::kChromeUIAboutURL), 144 WindowOpenDisposition::CURRENT_TAB, ui::PAGE_TRANSITION_TYPED, false));
145 content::Referrer(),
146 CURRENT_TAB,
147 ui::PAGE_TRANSITION_TYPED,
148 false));
149 runner->Run(); 145 runner->Run();
150 nav_entry_committed_callback_.Reset(); 146 nav_entry_committed_callback_.Reset();
151 } 147 }
152 148
153 } // namespace autofill 149 } // namespace autofill
OLDNEW
« no previous file with comments | « chrome/browser/autofill/autofill_browsertest.cc ('k') | chrome/browser/background/background_mode_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698