chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc

diff --git a/chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc b/chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc

index 61269fe242fb067bf63b8fc6197323acc57cbf24..940270ca6ef4c9b4208ea8918dac4837adef547e 100644

--- a/chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc

+++ b/chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc

@@ -216,7 +216,7 @@ void ExtensionAppShimHandler::Delegate::LaunchApp(

extension_misc::APP_LAUNCH_CMD_LINE_APP, extension->GetType());

if (extension->is_hosted_app()) {

OpenApplication(CreateAppLaunchParamsUserContainer(

- profile, extension, NEW_FOREGROUND_TAB,

+ profile, extension, WindowOpenDisposition::NEW_FOREGROUND_TAB,

extensions::SOURCE_COMMAND_LINE));

return;

}