Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3733)

Unified Diff: chrome/browser/android/tab_android.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/tab_android.cc
diff --git a/chrome/browser/android/tab_android.cc b/chrome/browser/android/tab_android.cc
index 463f277a10a7e9895fec518fca7e4d600a73be7c..cf6c1cc74a6d81e84d6db92598991b5c35fb8cd0 100644
--- a/chrome/browser/android/tab_android.cc
+++ b/chrome/browser/android/tab_android.cc
@@ -214,11 +214,11 @@ void TabAndroid::HandlePopupNavigation(chrome::NavigateParams* params) {
WindowOpenDisposition disposition = params->disposition;
const GURL& url = params->url;
- if (disposition == NEW_POPUP ||
- disposition == NEW_FOREGROUND_TAB ||
- disposition == NEW_BACKGROUND_TAB ||
- disposition == NEW_WINDOW ||
- disposition == OFF_THE_RECORD) {
+ if (disposition == WindowOpenDisposition::NEW_POPUP ||
+ disposition == WindowOpenDisposition::NEW_FOREGROUND_TAB ||
+ disposition == WindowOpenDisposition::NEW_BACKGROUND_TAB ||
+ disposition == WindowOpenDisposition::NEW_WINDOW ||
+ disposition == WindowOpenDisposition::OFF_THE_RECORD) {
JNIEnv* env = AttachCurrentThread();
ScopedJavaLocalRef<jobject> jobj = weak_java_tab_.get(env);
ScopedJavaLocalRef<jstring> jurl(ConvertUTF8ToJavaString(env, url.spec()));
@@ -227,9 +227,9 @@ void TabAndroid::HandlePopupNavigation(chrome::NavigateParams* params) {
ScopedJavaLocalRef<jobject> jpost_data;
if (params->uses_post && params->post_data)
jpost_data = params->post_data->ToJavaObject(env);
- Java_Tab_openNewTab(env, jobj, jurl, jheaders, jpost_data, disposition,
- params->created_with_opener,
- params->is_renderer_initiated);
+ Java_Tab_openNewTab(
+ env, jobj, jurl, jheaders, jpost_data, static_cast<int>(disposition),
+ params->created_with_opener, params->is_renderer_initiated);
} else {
NOTIMPLEMENTED();
}
« no previous file with comments | « chrome/browser/android/service_tab_launcher.cc ('k') | chrome/browser/android/tab_web_contents_delegate_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698