chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc b/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

index 7d371348302aef1900164d9b0d7131af50cced4e..30dd8cee53a305f16bdbe356bfb06ca9592af74c 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

@@ -176,7 +176,8 @@ bool BookmarkMenuDelegate::ShouldExecuteCommandWithoutClosingMenu(

int id,

const ui::Event& event) {

return (event.flags() & ui::EF_LEFT_MOUSE_BUTTON) &&

- ui::DispositionFromEventFlags(event.flags()) == NEW_BACKGROUND_TAB;

+ ui::DispositionFromEventFlags(event.flags()) ==

+ WindowOpenDisposition::NEW_BACKGROUND_TAB;

}

bool BookmarkMenuDelegate::GetDropFormats(