chrome/browser/printing/print_dialog_cloud.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_dialog_cloud.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/printing/print_dialog_cloud.cc

diff --git a/chrome/browser/printing/print_dialog_cloud.cc b/chrome/browser/printing/print_dialog_cloud.cc

index bdc280ecdc52b813bb92b8694c44d044c820817e..2491feff0b126c098a46b9507e09b99c66fd1be4 100644

--- a/chrome/browser/printing/print_dialog_cloud.cc

+++ b/chrome/browser/printing/print_dialog_cloud.cc

@@ -80,10 +80,8 @@ void CreateCloudPrintSigninTab(Browser* browser,

browser->OpenURL(content::OpenURLParams(

google_util::AppendGoogleLocaleParam(

url, g_browser_process->GetApplicationLocale()),

- content::Referrer(),

- NEW_FOREGROUND_TAB,

- ui::PAGE_TRANSITION_AUTO_BOOKMARK,

- false));

+ content::Referrer(), WindowOpenDisposition::NEW_FOREGROUND_TAB,

+ ui::PAGE_TRANSITION_AUTO_BOOKMARK, false));

new SignInObserver(web_contents, callback);

}