chrome/test/base/browser_with_test_window_test.h - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/browser_with_test_window_test.h

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/base/browser_with_test_window_test.h

diff --git a/chrome/test/base/browser_with_test_window_test.h b/chrome/test/base/browser_with_test_window_test.h

index ba85e3ff4712c396301b24756b58d21c40b05bbe..9792495e99f165498aea86c892746e659e891da7 100644

--- a/chrome/test/base/browser_with_test_window_test.h

+++ b/chrome/test/base/browser_with_test_window_test.h

@@ -61,7 +61,7 @@ class WebContents;

// // This is equivalent to the above, and lets you test pending navigations.

// browser()->OpenURL(OpenURLParams(

-// GURL("http://foo/2"), GURL(), CURRENT_TAB,

+// GURL("http://foo/2"), GURL(), WindowOpenDisposition::CURRENT_TAB,

// ui::PAGE_TRANSITION_TYPED, false));

// CommitPendingLoad(controller);