chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller_unittest.mm - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller_unittest.mm

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm ('k') | chrome/browser/ui/cocoa/browser_window_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller_unittest.mm

index 3aad9f82b242f9cf0cd80283038e9e662c82f299..f8266e3c1bb14823b7cd2cb909b1ae9f5ab83e9e 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller_unittest.mm

@@ -56,11 +56,11 @@ using bookmarks::BookmarkNode;

- (void)openAll:(NSInteger)tag

withDisposition:(WindowOpenDisposition)disposition {

- if (disposition == NEW_FOREGROUND_TAB) {

+ if (disposition == WindowOpenDisposition::NEW_FOREGROUND_TAB) {

opened_new_foreground_tab = YES;

- } else if (disposition == NEW_WINDOW) {

+ } else if (disposition == WindowOpenDisposition::NEW_WINDOW) {

opened_new_window = YES;

- } else if (disposition == OFF_THE_RECORD) {

+ } else if (disposition == WindowOpenDisposition::OFF_THE_RECORD) {

opened_off_the_record = YES;

}