chrome/browser/ui/sync/one_click_signin_links_delegate_impl.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_links_delegate_impl.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/sync/one_click_signin_links_delegate_impl.cc

diff --git a/chrome/browser/ui/sync/one_click_signin_links_delegate_impl.cc b/chrome/browser/ui/sync/one_click_signin_links_delegate_impl.cc

index 6c8a66d87d43f98646c7d3920df35aa4bf1a0a57..71f0cbe51d92869dbf803b225c270d0f6b334b48 100644

--- a/chrome/browser/ui/sync/one_click_signin_links_delegate_impl.cc

+++ b/chrome/browser/ui/sync/one_click_signin_links_delegate_impl.cc

@@ -19,7 +19,8 @@ OneClickSigninLinksDelegateImpl::~OneClickSigninLinksDelegateImpl() {}

void OneClickSigninLinksDelegateImpl::OnLearnMoreLinkClicked(bool is_dialog) {

chrome::NavigateParams params(browser_, GURL(chrome::kChromeSyncLearnMoreURL),

ui::PAGE_TRANSITION_LINK);

- params.disposition = is_dialog ? NEW_WINDOW : NEW_FOREGROUND_TAB;

+ params.disposition = is_dialog ? WindowOpenDisposition::NEW_WINDOW

+ : WindowOpenDisposition::NEW_FOREGROUND_TAB;

chrome::Navigate(&params);

}