Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3777)

Unified Diff: chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc
diff --git a/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc b/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc
index 0cd5e10be9c0318d4e295e0d512f97625bf7b1e8..2cb317b709f05c8d689a017d4d8d608332a16a40 100644
--- a/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc
+++ b/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc
@@ -310,8 +310,8 @@ void InlineLoginUIBrowserTest::SetAllowedUsernamePattern(
#define MAYBE_DifferentStorageId DifferentStorageId
#endif
IN_PROC_BROWSER_TEST_F(InlineLoginUIBrowserTest, MAYBE_DifferentStorageId) {
- ContentInfo info =
- NavigateAndGetInfo(browser(), GetSigninPromoURL(), CURRENT_TAB);
+ ContentInfo info = NavigateAndGetInfo(browser(), GetSigninPromoURL(),
+ WindowOpenDisposition::CURRENT_TAB);
WaitUntilUIReady(browser());
// Make sure storage partition of embedded webview is different from
@@ -340,12 +340,12 @@ IN_PROC_BROWSER_TEST_F(InlineLoginUIBrowserTest, OneProcessLimit) {
// still be given its own process and storage partition.
content::RenderProcessHost::SetMaxRendererProcessCount(1);
- ContentInfo info1 =
- NavigateAndGetInfo(browser(), test_url_1, CURRENT_TAB);
- ContentInfo info2 =
- NavigateAndGetInfo(browser(), test_url_2, CURRENT_TAB);
- ContentInfo info3 =
- NavigateAndGetInfo(browser(), GetSigninPromoURL(), CURRENT_TAB);
+ ContentInfo info1 = NavigateAndGetInfo(browser(), test_url_1,
+ WindowOpenDisposition::CURRENT_TAB);
+ ContentInfo info2 = NavigateAndGetInfo(browser(), test_url_2,
+ WindowOpenDisposition::CURRENT_TAB);
+ ContentInfo info3 = NavigateAndGetInfo(browser(), GetSigninPromoURL(),
+ WindowOpenDisposition::CURRENT_TAB);
ASSERT_EQ(info1.pid, info2.pid);
ASSERT_NE(info1.pid, info3.pid);
« no previous file with comments | « chrome/browser/ui/webui/signin/inline_login_handler_impl.cc ('k') | chrome/browser/ui/webui/signin/login_ui_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698