chrome/test/base/browser_with_test_window_test.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/browser_with_test_window_test.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/base/browser_with_test_window_test.cc

diff --git a/chrome/test/base/browser_with_test_window_test.cc b/chrome/test/base/browser_with_test_window_test.cc

index 967d987a9767d7bd18ab6778fd9090bf329c94f7..3ceadfb6f0339da8abe9814b1cea84bb5866b2ad 100644

--- a/chrome/test/base/browser_with_test_window_test.cc

+++ b/chrome/test/base/browser_with_test_window_test.cc

@@ -117,7 +117,7 @@ gfx::NativeWindow BrowserWithTestWindowTest::GetContext() {

void BrowserWithTestWindowTest::AddTab(Browser* browser, const GURL& url) {

chrome::NavigateParams params(browser, url, ui::PAGE_TRANSITION_TYPED);

params.tabstrip_index = 0;

- params.disposition = NEW_FOREGROUND_TAB;

+ params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;

chrome::Navigate(&params);

CommitPendingLoad(&params.target_contents->GetController());

}