Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: chrome/browser/history/redirect_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_browsertest.cc ('k') | chrome/browser/infobars/infobar_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/redirect_browsertest.cc
diff --git a/chrome/browser/history/redirect_browsertest.cc b/chrome/browser/history/redirect_browsertest.cc
index d1ae3db51a1db278d96c7d43402842693b069ee8..b1e8d2d013adcdcfbbcd8be5e9f38538376c4068 100644
--- a/chrome/browser/history/redirect_browsertest.cc
+++ b/chrome/browser/history/redirect_browsertest.cc
@@ -282,13 +282,15 @@ IN_PROC_BROWSER_TEST_F(RedirectTest,
content::TestNavigationObserver observer(web_contents, 2);
ui_test_utils::NavigateToURLWithDisposition(
- browser(), first_url, CURRENT_TAB, ui_test_utils::BROWSER_TEST_NONE);
+ browser(), first_url, WindowOpenDisposition::CURRENT_TAB,
+ ui_test_utils::BROWSER_TEST_NONE);
// We don't sleep here - the first navigation won't have been committed yet
// because we told the server to wait a minute. This means the browser has
// started it's provisional load for the client redirect destination page but
// hasn't completed. Our time is now!
ui_test_utils::NavigateToURLWithDisposition(
- browser(), final_url, CURRENT_TAB, ui_test_utils::BROWSER_TEST_NONE);
+ browser(), final_url, WindowOpenDisposition::CURRENT_TAB,
+ ui_test_utils::BROWSER_TEST_NONE);
observer.Wait();
// Check to make sure the navigation did in fact take place and we are
« no previous file with comments | « chrome/browser/history/history_browsertest.cc ('k') | chrome/browser/infobars/infobar_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698