chrome/browser/ui/webui/webui_browsertest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/webui_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/webui_browsertest.cc

diff --git a/chrome/browser/ui/webui/webui_browsertest.cc b/chrome/browser/ui/webui/webui_browsertest.cc

index df3a881d53ef8e8c1cbbfb130dfcc88b8cefccb8..662e6cec6229660ca88dca9d4b5dd70f2704661f 100644

--- a/chrome/browser/ui/webui/webui_browsertest.cc

+++ b/chrome/browser/ui/webui/webui_browsertest.cc

@@ -78,14 +78,14 @@ IN_PROC_BROWSER_TEST_F(WebUIImplBrowserTest, InPageNavigationsAndReload) {

ASSERT_TRUE(content::ExecuteScript(

browser()->tab_strip_model()->GetActiveWebContents(),

"window.history.pushState({}, '', 'foo.html')"));

- chrome::GoBack(browser(), CURRENT_TAB);

+ chrome::GoBack(browser(), WindowOpenDisposition::CURRENT_TAB);

content::WaitForLoadStop(

browser()->tab_strip_model()->GetActiveWebContents());

// Test handler should still have JavaScript allowed after in-page navigation.

EXPECT_TRUE(test_handler->IsJavascriptAllowed());

- chrome::Reload(browser(), CURRENT_TAB);

+ chrome::Reload(browser(), WindowOpenDisposition::CURRENT_TAB);

content::WaitForLoadStop(

browser()->tab_strip_model()->GetActiveWebContents());