extensions/browser/extension_host.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_host.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/extension_host.cc

diff --git a/extensions/browser/extension_host.cc b/extensions/browser/extension_host.cc

index 352619a895edb79491b67403875e0573b54fc473..63e5c658382b9eeeb8a4bd73e9be2f6213d05cff 100644

--- a/extensions/browser/extension_host.cc

+++ b/extensions/browser/extension_host.cc

@@ -427,7 +427,7 @@ void ExtensionHost::AddNewContents(WebContents* source,

// vice versa.

// Note that we don't do this for popup windows, because we need to associate

// those with their extension_app_id.

- if (disposition != NEW_POPUP) {

+ if (disposition != WindowOpenDisposition::NEW_POPUP) {

WebContents* associated_contents = GetAssociatedWebContents();

if (associated_contents &&

associated_contents->GetBrowserContext() ==