chrome/browser/chromeos/extensions/echo_private_api.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/echo_private_api.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/extensions/echo_private_api.cc

diff --git a/chrome/browser/chromeos/extensions/echo_private_api.cc b/chrome/browser/chromeos/extensions/echo_private_api.cc

index 7af780ebfd920c57bfeb849f41065eccc450333b..7027a338db6d0daa48359fcb41f982bd5df0e429 100644

--- a/chrome/browser/chromeos/extensions/echo_private_api.cc

+++ b/chrome/browser/chromeos/extensions/echo_private_api.cc

@@ -207,7 +207,7 @@ void EchoPrivateGetUserConsentFunction::OnMoreInfoLinkClicked() {

GetProfile(), GURL(kMoreInfoLink), ui::PAGE_TRANSITION_LINK);

// Open the link in a new window. The echo dialog is modal, so the current

// window is useless until the dialog is closed.

- params.disposition = NEW_WINDOW;

+ params.disposition = WindowOpenDisposition::NEW_WINDOW;

chrome::Navigate(&params);

}