Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Implements the Chrome Extensions WebNavigation API. 5 // Implements the Chrome Extensions WebNavigation API.
6 6
7 #include "chrome/browser/extensions/api/web_navigation/web_navigation_api.h" 7 #include "chrome/browser/extensions/api/web_navigation/web_navigation_api.h"
8 8
9 #include "base/lazy_instance.h" 9 #include "base/lazy_instance.h"
10 #include "chrome/browser/chrome_notification_types.h" 10 #include "chrome/browser/chrome_notification_types.h"
(...skipping 356 matching lines...) Expand 10 before | Expand all | Expand 10 after
367 content::RenderFrameHost* source_render_frame_host, 367 content::RenderFrameHost* source_render_frame_host,
368 const GURL& url, 368 const GURL& url,
369 const content::Referrer& referrer, 369 const content::Referrer& referrer,
370 WindowOpenDisposition disposition, 370 WindowOpenDisposition disposition,
371 ui::PageTransition transition) { 371 ui::PageTransition transition) {
372 if (!navigation_state_.CanSendEvents(source_render_frame_host)) 372 if (!navigation_state_.CanSendEvents(source_render_frame_host))
373 return; 373 return;
374 374
375 // We only send the onCreatedNavigationTarget if we end up creating a new 375 // We only send the onCreatedNavigationTarget if we end up creating a new
376 // window. 376 // window.
377 if (disposition != SINGLETON_TAB && 377 if (disposition != WindowOpenDisposition::SINGLETON_TAB &&
378 disposition != NEW_FOREGROUND_TAB && 378 disposition != WindowOpenDisposition::NEW_FOREGROUND_TAB &&
379 disposition != NEW_BACKGROUND_TAB && 379 disposition != WindowOpenDisposition::NEW_BACKGROUND_TAB &&
380 disposition != NEW_POPUP && 380 disposition != WindowOpenDisposition::NEW_POPUP &&
381 disposition != NEW_WINDOW && 381 disposition != WindowOpenDisposition::NEW_WINDOW &&
382 disposition != OFF_THE_RECORD) 382 disposition != WindowOpenDisposition::OFF_THE_RECORD)
383 return; 383 return;
384 384
385 helpers::DispatchOnCreatedNavigationTarget(web_contents(), 385 helpers::DispatchOnCreatedNavigationTarget(web_contents(),
386 new_contents->GetBrowserContext(), 386 new_contents->GetBrowserContext(),
387 source_render_frame_host, 387 source_render_frame_host,
388 new_contents, 388 new_contents,
389 url); 389 url);
390 } 390 }
391 391
392 void WebNavigationTabObserver::WebContentsDestroyed() { 392 void WebNavigationTabObserver::WebContentsDestroyed() {
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
577 return g_factory.Pointer(); 577 return g_factory.Pointer();
578 } 578 }
579 579
580 void WebNavigationAPI::OnListenerAdded(const EventListenerInfo& details) { 580 void WebNavigationAPI::OnListenerAdded(const EventListenerInfo& details) {
581 web_navigation_event_router_.reset(new WebNavigationEventRouter( 581 web_navigation_event_router_.reset(new WebNavigationEventRouter(
582 Profile::FromBrowserContext(browser_context_))); 582 Profile::FromBrowserContext(browser_context_)));
583 EventRouter::Get(browser_context_)->UnregisterObserver(this); 583 EventRouter::Get(browser_context_)->UnregisterObserver(this);
584 } 584 }
585 585
586 } // namespace extensions 586 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_test.cc ('k') | chrome/browser/extensions/api/web_request/web_request_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698